Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix: Error thrown from channel mention in webhook #372

Merged
merged 1 commit into from
Dec 15, 2023
Merged

Fix: Error thrown from channel mention in webhook #372

merged 1 commit into from
Dec 15, 2023
+3 −0

Conversation

Blocksnmore
Copy link
Contributor

About

Closes #370

Skips fetching channel info if this.client is undefined as is the case in a webhook message thus not causing a crash

Status

  • These changes have been tested against Discord API or do not contain API change.
  • This PR includes only documentation changes, no code change.
  • This PR introduces some Breaking changes.

Helloyunho
Helloyunho approved these changes Nov 12, 2023
View reviewed changes
Copy link
Member

@Helloyunho Helloyunho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm!

@Helloyunho Helloyunho merged commit 04bbcfc into harmonyland:main Dec 15, 2023
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Helloyunho Helloyunho Helloyunho approved these changes

@DjDeveloperr DjDeveloperr Awaiting requested review from DjDeveloperr

@AkiaCode AkiaCode Awaiting requested review from AkiaCode

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[Bug] Webhook.send throws exception when channels mentioned
2 participants
@Blocksnmore @Helloyunho